[SPARK-52472] Regenerate Spark Connect-generated Swift source code with protoc-gen-grpc-swift-2
#198
+15
−275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with protoc-gen-grpc-swift-2
dongjoon-hyun
commented
Jun 13, 2025
| reservedRanges: [1..<3], | ||
| numberNameMappings: [ | ||
| 3: .same(proto: "hash"), | ||
| ]) |
There was a problem hiding this comment.
This is the only non-trivial change.
dongjoon-hyun
changed the title
Spark Connect-generated Swift source code with protoc-gen-grpc-swift-2Spark Connect-generated Swift source code with protoc-gen-grpc-swift-2
viirya
approved these changes
Jun 13, 2025
viirya
reviewed
Jun 13, 2025
| @@ -1887,15 +1887,11 @@ extension Spark_Connect_Expression: SwiftProtobuf.Message, SwiftProtobuf._Messag | |||
| var _common: Spark_Connect_ExpressionCommon? = nil | |||
| var _exprType: Spark_Connect_Expression.OneOf_ExprType? | |||
|
|
|||
| #if swift(>=5.10) | |||
There was a problem hiding this comment.
Hmm, wonder why it removed the version check condition.
There was a problem hiding this comment.
Yes, it's removed because Swift-GRPC supports Swift 5.10+ only now, @viirya .
Swift 6.2 feature freeze was started too and Swift-GRPC will support Swift 6.1+ only when 6.2 is out.
There was a problem hiding this comment.
BTW, Apache Spark Connect for Swift starts with Swift 6.0+.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to regenerate
Spark Connect-generated Swift source code withprotoc-gen-grpc-swift-2.Why are the changes needed?
These files are manually generated from v4.0.0 tag by the following standard procedures.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.